Opt in to stricter TypeScript checks #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wycats
changed the title
wycats
force-pushed
the
chore/stricter-ts
branch
2 times, most recently
from
dd43f67
to
95edfd1
Compare
- exactOptionalPropertyTypes - noPropertyAccessFromIndexSignature - noImplicitOverride This commit also cleans up deprecated lints, migrates older lints to `n/` and sets up the import lint plugins needed for a good importing experience. There's a lot of changes in this commit, but most of it is minor tweaks to deal with stylistic issues raised by lints. The biggest substantive changes were required by `exactOptionalPropertyTypes` and `noPropertyAccessFromIndexSignature`. Both of these strict settings revealed many places where our code didn't clearly handle missing values and nulls, and this commit adds the necessary checks. Some common patterns: - Migrate C-style for loops to for/of loops, which eliminates nulls - Pervasive use of the (already existing) `PresentArray` pattern and its utilities. Added `getFirst` and `getLast` utilities, as well as some variations on the present array checks. - Used `?` to propagate undefined in testing situations where undefined would fail equality checks anyway.
wycats
force-pushed
the
chore/stricter-ts
branch
3 times, most recently
from
f6bea85
to
c27416b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable strictest TS settings and fix lints
This commit also cleans up deprecated lints, migrates older lints to
n/and sets up the import lint plugins needed for a good importingexperience.
There's a lot of changes in this commit, but most of it is minor tweaks
to deal with stylistic issues raised by lints.
The biggest substantive changes were required by
exactOptionalPropertyTypesandnoPropertyAccessFromIndexSignature.Both of these strict settings revealed many places where our code didn't
clearly handle missing values and nulls, and this commit adds the
necessary checks.
Some common patterns:
PresentArraypattern and itsutilities. Added
getFirstandgetLastutilities, as well as somevariations on the present array checks.
?to propagate undefined in testing situations where undefinedwould fail equality checks anyway.